Skip to content

Fix invalid components in Chakra UI #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 5, 2025
Merged

Fix invalid components in Chakra UI #964

merged 8 commits into from
Aug 5, 2025
+15 −15

Conversation

@vipocenka
Copy link
Contributor

@vipocenka vipocenka commented Mar 5, 2025 •
edited
Loading

Updated all remaining instances of align="left" to align="start" across all files and components:

  • page.tsx
  • projects/page.tsx
  • Carousel.tsx
  • InfoCard.tsx
  • ProjectsList.tsx
  • SectionBlock.tsx

@vipocenka vipocenka requested a review from a team as a code owner March 5, 2025 19:35
vplasencia
vplasencia reviewed May 25, 2025
View reviewed changes
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vipocenka! Thank you very much for creating this PR. Could you update the remaining occurrences of align="left"?

@vipocenka
Copy link
Contributor Author

vipocenka commented May 31, 2025

@vplasencia Hi!
Updated all remaining instances of align="left" to align="start" across all files and components:

  • page.tsx
  • projects/page.tsx
  • Carousel.tsx
  • InfoCard.tsx
  • ProjectsList.tsx
  • SectionBlock.tsx

vplasencia
vplasencia requested changes Jun 3, 2025
View reviewed changes
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vipocenka! Thank you very much for the updates. I just left two comments.

@vipocenka
Copy link
Contributor Author

vipocenka commented Jun 5, 2025

Hi @vplasencia,
I've reverted the textAlign="start" back to textAlign="left" in the places you mentioned in InfoCard.tsx, as requested.
Let me know if there's anything else that needs adjustment.

vplasencia
vplasencia requested changes Jun 20, 2025
View reviewed changes
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vipocenka!

It looks great! Thank you for the updates. Could you update in InfoCard.tsx line 28 align="left" with align="start"?

@vipocenka
Copy link
Contributor Author

vipocenka commented Jul 10, 2025

Hi @vplasencia!
Thanks for pointing that out — I’ve updated align="left" to align="start" in InfoCard.tsx on line 28 as requested. Let me know if there’s anything else I should adjust!

@vipocenka
Copy link
Contributor Author

vipocenka commented Aug 5, 2025

Hi @vplasencia!

I’ve updated align="left" to align="start" on line 28 of InfoCard.tsx as requested. Could you please take another look and approve when you have a moment? Thanks! 🙏

vplasencia
vplasencia approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vipocenka! It looks great! Thank you very much! 🚀

@vplasencia vplasencia merged commit 53f4187 into semaphore-protocol:main Aug 5, 2025
4 checks passed
@gitpoap-bot
Copy link

gitpoap-bot bot commented Aug 5, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Semaphore Contributor:

GitPOAP: 2025 Semaphore Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vplasencia vplasencia vplasencia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vipocenka @vplasencia